@adriennetacke
Conducting Humane Code Reviews
I wrote a book
I teach others on LinkedIn Learning
I talked about Azure Durable Functions yesterday!
✋🏼✋✋🏿
Who has performed a code review?
Why do we perform code reviews?
// AKA our Ideal Code Review Goals
Catch design flaws
Ideal Code Review Goals
Ensure code clarity and coherence
Ideal Code Review Goals
Validate necessity
Ideal Code Review Goals
Confirm functionality
Ideal Code Review Goals
✋🏼✋✋🏿
Who loves doing a code review?
Why?
Top Three Code Review Complaints
(and what we can do about them!)
Subjectivity
Tone of Voice
Process Loopholes
Subjectivity
Tone of Voice
Process Loopholes
What's subjective?
From a pull request for the materialize repo
From a pull request for the handsontable repo
"You should really indent lines 23 and 27."
"Replace var with const! C'mon, it's 2020!"
"I'd rather use regexes here."
"TotalNumberOfUsers is better than TotalUsers."
...What we can do better?
Before you do ANYTHING, gain consensus with your team!
Develop a Team Working Agreement and enforce it!
What's a Team Working Agreement?
🤖
Let the robots take over!
(they're better at it anyway)
Prettier and ESLint have saved team relationships!
EditorConfig && Roslyn analyzers = 💛
Objectivity Always Wins
What's Objective?
"This change should probably go into our utils library. It will be re-used quite a bit!"
"I've run this on several browsers and this toast actually pops up on the top-right but our ticket specifies bottom-right! Can we fix it so it matches our requirements?"
"I'm having trouble keeping up with the logic on lines 457-464. Is there a way we can simplify it or make it clearer?"
"This method is being deprecated in two weeks! I'd suggest replacing it with the authenticateUser method from our authentication library!"
🥰
If you see something you like,
say so!
Subjectivity
Tone of Voice
Process Loopholes
Subjectivity
Tone of Voice
Process Loopholes
From a pull request for the materialize repo